Advanced Minds

While cleaning up parisc_ksyms.c earlier, I noticed that strpbrk wasn't being exported from lib/string.c. Investigating further, I noticed a changeset that removed its export and added it to _ksyms.c on a few more architectures. The justification was that other arches do it. I think this is wrong, since no architecture currently defines __HAVE_ARCH_STRPBRK, there's no reason for any of them to be exporting it themselves. Therefore, consolidate the export to lib/string.c. Signed-off-by: Kyle McMartin < This e-mail address is being protected from spam bots, you need JavaScript enabled to view it

I think this is wrong, since no architecture currently defines __HAVE_ARCH_STRPBRK, there's no reason for any of them to be exporting it themselves. Therefore, consolidate the export to lib/string.c. I noticed this too the other day, and I totally agree. Thanks for taking care of this. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to This e-mail address is being protected from spam bots, you need JavaScript enabled to view it More majordomo info at  http://vger.kernel.org/majordomo-info.html Please read the FAQ at  http://www.tux.org/lkml/